fix: avoid self-deadlock in auto-merge-release-pr - #84
Merged
Conversation
gh pr checks --watch includes this job's own check run, which never turns green until the step finishes, so the job waited on itself forever. Poll manually and exclude any check whose link points at the current run instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Found while testing nullplatform/services-postgresql-rds#7: the `automerge` job used `gh pr checks --watch --fail-fast` to wait for the release PR's checks before merging. That command waits for all checks on the PR — including the `automerge` job's own check run, which can't turn green until the step finishes. Result: the job waited on itself indefinitely.
Fix
Replaced the watch with a manual poll (15s interval, ~22min cap) that fetches
gh pr checks --json name,state,linkand excludes any check whoselinkpoints at the current run (/runs/<run_id>/), then fails fast on any real failure and times out loudly instead of hanging or silently merging.Test plan